On 03.08.2010 18:14, Patrick Ohly wrote: > On Tue, 2010-08-03 at 18:22 +0300, Oliver Hartkopp wrote: >>>> The flags are tested all together in skb_orphan_try() ... >>> >>> This is why I hate using unions in situations like this... it makes >>> code impossible to audit easily. >>> >>> This damn thing should just be a "u8 flags" and a bunch of bit mask >>> CPP macro defines for the various boolean values. >> >> Yep! I also felt like this. >> >> Maybe Patrick Ohly can give some feedback, if he's ok with that kind of >> change. So far there are only a few places that would need to be changed for >> the flags bitops. > > I'm fine with using a simple u8. I'm not sure where I picked up the > union thing, it's not something that I usually do in my own code. >
:-) Im currently busy until next week, would you like to provide a patch? Regards, Oliver _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
