Hi Sam, > > The CAN driver has been tested for bitrates from 3.5Kbps to 1Mbps > with linux kernel 2.6.32 > > This patch-set is generated against socketCAN trunk SVN version 1194. > Protection for different linux kernel versions has been added using > LINUX_VERSION_CODE macros. > > Any particular reason why you did not develop on top of the 2.6.35 > kernel? > The SVN stuff is for backward compatibility reasons only.
I am in parallel preparing the patch against david miller's 2.6.35 and I will try to get it pushed in the netdev-next mailing list in the coming days. However, I wished to get some review comments from this list before submitting the same, mainly because the reference of this driver is the old bosch CCAN driver present in the SVN tree. > > General comment: > Keep your line length below ~70 in changelogs and mails. > The source code looks very good for a first submission from a style > point of view. Ok. Thanks for the inputs. I will keep this in mind. Regards, Bhupesh _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
