Hi Matthias, > -----Original Message----- > From: Matthias Fuchs [mailto:[email protected]] > Sent: Thursday, August 26, 2010 2:46 PM > To: Bhupesh SHARMA > Cc: [email protected] > Subject: Re: [RFC PATCH 2/4] Boch CCAN driver > > Hi Bhupesh, > > > Index: bosch_ccan.c > > =================================================================== > > --- bosch_ccan.c (revision 0) > > +++ bosch_ccan.c (revision 0) > > + priv = netdev_priv(dev); > > + > > + priv->dev = dev; > > + priv->can.bittiming_const = &bosch_ccan_bittiming_const; > > + priv->can.do_set_bittiming = bosch_ccan_set_bittiming; > > + priv->can.do_get_state = bosch_ccan_get_state; > > + priv->can.do_set_mode = bosch_ccan_set_mode; > > + > > + return dev; > What about filling priv->can.ctrlmode_supported? > > I think the following modes should be possible with CCANs: > > CAN_CTRLMODE_LOOPBACK | CAN_CTRLMODE_LISTENONLY | CAN_CTRLMODE_ONE_SHOT > | CAN_CTRLMODE_BERR_REPORTING > > CAN_CTRLMODE_BERR_REPORTING is probably the most interesting of those > :-) >
Yes. I think I completely overlooked the CAN_CTRLMODE stuff. It will be added in V2 of this patch. Regards, Bhupesh _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
