From: Wolfgang Grandegger <[email protected]> Date: Tue, 31 Aug 2010 21:22:07 +0200
> On 08/31/2010 09:10 PM, Wolfram Sang wrote: >> On Tue, Aug 31, 2010 at 07:44:00PM +0200, Julia Lawall wrote: >>> Add a call to of_node_put in the error handling code following a call to >>> of_find_matching_node. >>> >>> This patch also moves the existing call to of_node_put after the call to >>> iounmap in the error handling code, to make it possible to jump to >>> of_node_put without doing iounmap. These appear to be disjoint operations, >>> so the ordering doesn't matter. >>> >>> This patch furthermore changes the -ENODEV result in the error handling >>> code for of_find_matching_node to a return of 0, as found in the error >>> handling code for of_iomap, because the return type of the function is >>> unsigned. >>> >>> The semantic match that finds this problem is as follows: >>> (http://coccinelle.lip6.fr/) ... >>> Signed-off-by: Julia Lawall <[email protected]> >> >> Reviewed-by: Wolfram Sang <[email protected]> > > Acked-by: Wolfgang Grandegger <[email protected]> Applied. _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
