On Mon, Mar 14, 2011 at 05:42:23PM +0100, Eric Dumazet wrote: > Le lundi 14 mars 2011 à 16:02 +0100, Kurt Van Dijck a écrit : > > > I see your point. > > The reason I modified this was, as described, checkpatch.pl was complaining. > > Anyway, this sequence was protected by a spinlock 'proto_tab_lock'. > > I don't think it was a race. > > > > Did I miss something? > > As soon as proto_tab[proto] = cp; is done, another thread on another cpu > can read the pointer and follow it. > > Hmm, I missed can_create() also uses the spinlock protection, so you're > probably right. > > It seems a bit overkill :( > phonet uses RCU for example. I'll keep that in mind. Switching CAN protos to RCU is far beyond to goal of this patch :-)
Thanks, Kurt _______________________________________________ Socketcan-core mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-core
