On 09/14/11 15:01, Oliver Hartkopp wrote:
> On 09/13/11 09:56, Marc Kleine-Budde wrote:
>
To minimize the discussion i removed many of the unlikely error messages.
It's getting smaller each time ;-)
--- ems_pcmcia.c~ 2011-09-12 20:29:01.108365646 +0200
+++ ems_pcmcia.c 2011-09-14 15:12:18.585783929 +0200
@@ -195,8 +195,6 @@
/* Check for unique EMS CAN signature */
if (readw(card->base_addr) != 0xAA55) {
- printk(KERN_ERR "%s: No EMS CPC Card hardware found.\n",
- DRV_NAME);
err = -ENODEV;
goto failure_cleanup;
}
@@ -237,8 +235,6 @@
/* Register SJA1000 device */
err = register_sja1000dev(dev);
if (err) {
- printk(KERN_INFO "%s: registering device "
- "failed (err=%d)\n", DRV_NAME, err);
free_sja1000dev(dev);
goto failure_cleanup;
}
@@ -254,17 +250,12 @@
err = request_irq(dev->irq, &ems_pcmcia_interrupt, IRQF_SHARED,
DRV_NAME, card);
- if (err) {
- printk(KERN_INFO "Registering device failed (err=%d)\n", err);
- goto failure_cleanup;
- }
-
- return 0;
+ if (!err)
+ return 0;
failure_cleanup:
- printk(KERN_ERR "Error: %d. Cleaning Up.\n", err);
+ printk(KERN_ERR "%s: registering device failed (err=%d)\n", DRV_NAME,
err);
ems_pcmcia_del_card(pdev);
-
return err;
}
_______________________________________________
Socketcan-core mailing list
Socketcan-core@lists.berlios.de
https://lists.berlios.de/mailman/listinfo/socketcan-core
