On 09/21/2011 11:24 AM, Arnd Bergmann wrote: > On Wednesday 21 September 2011 10:33:10 Wolfgang Grandegger wrote: >> >>> Since most ISA drivers don't actually use isa_register_driver >>> (for good or bad), how about changing the Kconfig entry for >>> the ones you need to 'depends on ISA || PLAT_GRANDEGGER_PC104_ATOM' >>> or similar? >> >> What should the PLAT_GRANDEGGER_PC104_ATOM be good for? If I replace >> isa_register_driver() with platform_driver_register(), like the serial >> 8250 driver does, HAS_IOMEM should be just fine. This would then also >> avoid the 64-bit trouble expected with old ISA drivers (enabled via >> ISA). Or have I missed something? > > I was thinking of the drivers that are for ISA cards but don't actually > use the isa_register_driver() function. If you have to change the driver > to a platform driver, you are right.
OK, then I will finally convert the sja1000_isa driver to a platform driver instead of allowing CONFIG_ISA for x86_64. > The other point is that you are probably using inb/outb operations, > which I'm trying to provide only on ISA/PCMCIA/PCI based systems in > the future. Once I finish that work, you will also need to depend on > HAS_IOPORT (which currently means something else). OK, the sja1000_isa driver just uses memory mapped access. Wolfgang. _______________________________________________ Socketcan-core mailing list Socketcan-core@lists.berlios.de https://lists.berlios.de/mailman/listinfo/socketcan-core
