Hi Wolfgang, On Wed, Oct 28, 2009 at 07:49:04PM +0100, Wolfgang Grandegger wrote: > Hi Fu, > > Luotao Fu wrote: > > Hi, > > > > On Wed, Oct 28, 2009 at 04:45:10PM +0100, Wolfgang Grandegger wrote: ... > We can blame the hardware, but it will not help us. We need a proper > workaround sooner than later. >
definitively > > behaviour. Nevertheless It awed to be worked around somehow. What do you > > think about kicking out the loop checking for SLPAK, so that we will > > give the controller a small chance to first get to sleep mode and > > otherwise reinit any way. This is ugly, since it still could break the > > bus somehow in rare conditions, however this still better than a > > controller, which will get stucked for sure for certain scenarios. > > That's a resonable option, indeed, if it works. Also, it would give us > some time to understand the real cause of the problem. > It will work all right. I mean that's still a small portion of posisibillities, that the mscan cannot finish the task it is doing 255*100us after the slprq reaches. This is imho quite impossible though. I will send out a new patch tommorow. > > Or we could add a flag to save the status of slprq while closing the > > device and check it again while reopening, so that we could at least > > get a clue, which is going wrong. With the current driver this problem > > is not even catched, which is also bad. What do you think? > > The error conditions should be checked. Everthing else is a bug. I > remember, that the start and stop of the MSCAN was tricky from the > beginning. I will have a look in other drivers how similar error conditions, if any, is handeld and try to make an extra patch for this. Cheers Fu -- Pengutronix e.K. | Dipl.-Ing. Luotao Fu | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
signature.asc
Description: Digital signature
_______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
