On 08/04/2011 10:25 AM, Wolfgang Grandegger wrote: > On 08/04/2011 10:09 AM, Wolfgang Grandegger wrote: >> Hi Robin, >> >> On 08/04/2011 05:23 AM, Robin Holt wrote: >>> I have spent some more time working on this. I took their code from the >>> April BSP and am reworking it to be a much cleaner (IMHO) implementation. >>> Hopefully I will have a set of patches for you tomorrow. >>> >>> Right now, I am down to the point of getting the _probe function >>> abstracted off. I think I will get it fairly clean when I am completed. >> >> Not sure what are you trying to do? What is missing in the mainline >> Flexcan driver are the device tree bindings. Unfortunately, Freescale's >> driver is not a good approach. I think it can be done much simpler, >> especially with the new device-tree integration available in v3.0. >> Robin, you have the mainline kernel running for a P1010 board, right? > > You patches are a good starting point for discussion...
Have you already posted them? From my point of view there are two problems: - OF tree integration (iomem, irq, clock) - endianess The fsl driver assumes that OF tree means a big endian hardware, this is not true for arm, where we have OF tree now. cheers, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Socketcan-users mailing list [email protected] https://lists.berlios.de/mailman/listinfo/socketcan-users
