On Thu, Aug 04, 2011 at 10:17:24PM +0200, Wolfgang Grandegger wrote:
> On 08/04/2011 09:54 PM, Marc Kleine-Budde wrote:
> > On 08/04/2011 09:15 PM, Robin Holt wrote:
> >> It looks like the of_device stuff got moved under the
> >> platform_device->driver and all we should need to do is define an
> >> of_match to get a .probe call out.  Give this a try.
> > 
> > have you tested the driver on PPC? what about the clock stuff, does it
> > work properly?
> > 
> >>
> >> Signed-off-by: Robin Holt <[email protected]>
> >> To: Marc Kleine-Budde <[email protected]>
> >> To: Wolfgang Grandegger <[email protected]>
> >> Cc: [email protected]
> >> ---
> >>  drivers/net/can/flexcan.c |   12 +++++++++++-
> >>  1 files changed, 11 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> >> index 74b1706..75e4d9c 100644
> >> --- a/drivers/net/can/flexcan.c
> >> +++ b/drivers/net/can/flexcan.c
> >> @@ -1033,8 +1033,18 @@ static int __devexit flexcan_remove(struct 
> >> platform_device *pdev)
> >>    return 0;
> >>  }
> >>  
> >> +static struct of_device_id flexcan_of_match[] = {
> >> +  {
> >> +          .compatible = "fsl,flexcan-v1.0",
> >> +  },
> >> +};
> > 
> > I think you have to NULL-terminate that list.
> 
> And also please remove "-v1.0". We could add  "fsl,flexcan-vx.x" later
> when it is really needed.

Removed.

Robin
_______________________________________________
Socketcan-users mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/socketcan-users

Reply via email to