Dear all,
I'm trying to update sofia-sip to the latest git version.
Is it possible to have the function nua_handle_by_call_id exported ?
(nua_h.patch)I recently moved to Windows 7 and I noticed that there are many tests that are failing (I suspect that is due to the co-existence of IPv4 and IPv6 stack, but I'll be more precise later, and I can provide also logs if needed) torture_su is failing on 7 (not on XP) due to the fact that the call of accept (on test test_sendrecv) returns INVALID_SOCKET (-1) with GetLastError = WSAEWOULDBLOCK (The socket is marked as nonblocking and no connections are present to be accepted) (http://msdn.microsoft.com/en-us/library/ms737526(VS.85).aspx) The patch attached (torture_su.patch) simply set the socket l as blocking to avoid this situation There is also a patch that I proposed some month ago (mail sent on 21st April attached) regarding the media direction (sendrecv/sendonly/recvonly) negotiation (soa_static.patch) Could you kindly review these patches ? Thanks in advance Regards, Filippo Della Betta Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie. This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks. [cid:00000000000000000000000000000001@TI.Disclaimer]Rispetta l'ambiente. Non stampare questa mail se non ? necessario.
nua_h.patch
Description: nua_h.patch
torture_su.patch
Description: torture_su.patch
soa_static.patch
Description: soa_static.patch
--- Begin Message ---Dear Pekka,all I noticed a strange behavior while receiving a "sendrecv" media offer when user descriptor is set to "recvonly". The expected result should be "recvonly", while sofia-sip set "sendrecv" (omits it). In my opinion the code at soa_static.c line 1047 should be modified as below. What do you think ? Thanks in advance Filippo Della Betta Old code send_mode = (sdp_mode_t)(um->m_mode & sdp_sendonly); if (rm) send_mode = (rm->m_mode & sdp_recvonly) ? sdp_sendonly : 0; recv_mode = (sdp_mode_t)(um->m_mode & sdp_recvonly); if (rm && rm->m_mode == sdp_inactive) { send_mode = recv_mode = (sdp_mode_t)0; } else if (inactive_all) { send_mode = recv_mode = (sdp_mode_t)0; } New code send_mode = (sdp_mode_t)(um->m_mode & sdp_sendonly); if (rm) send_mode = send_mode & ( (rm->m_mode & sdp_recvonly) ? sdp_sendonly : sdp_inactive ); recv_mode = (sdp_mode_t)(um->m_mode & sdp_recvonly); if (rm) recv_mode = recv_mode & ( (rm->m_mode & sdp_sendonly) ? sdp_recvonly : sdp_inactive ); if (inactive_all) { send_mode = recv_mode = (sdp_mode_t)0; }
--- End Message ---
<<inline: logo Ambiente_foglia.jpg>>
------------------------------------------------------------------------------ Sell apps to millions through the Intel(R) Atom(Tm) Developer Program Be part of this innovative community and reach millions of netbook users worldwide. Take advantage of special opportunities to increase revenue and speed time-to-market. Join now, and jumpstart your future. http://p.sf.net/sfu/intel-atom-d2d
_______________________________________________ Sofia-sip-devel mailing list Sofia-sip-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/sofia-sip-devel
