Hi,
just noticed that you did merge some of my previous CLE266 patch into
CVS, but missed some portions of it:
- The aspect_ratio_info is somehow 221.0/110 altought it really should
be 2.21 as defined in Table 6-3 of ISO/IEC 13818-2. What's the story
behind this non-standard value?
- It seems that you didn't want to remove support from older
libcle266mpecdec libraries that cannot even be downloaded anywhere
anymore. :) Anyway I prefer to check the presence of the library with
pkg-config's "--atleast-version=" instead of "--cflags". If you want to
support all versions of the library, just use the
"--atleast-version=0.1" parameter.
BR,
--
rofa
Index: configure
===================================================================
RCS file: /cvsroot/softdevice/softdevice/configure,v
retrieving revision 1.25
diff -u -r1.25 configure
--- configure 16 Sep 2006 09:30:19 -0000 1.25
+++ configure 16 Sep 2006 19:43:58 -0000
@@ -327,23 +327,19 @@
fi
#########################################################
-# cle266mpegdec: check if present
+# libcle266mpegdec: check if required version is present
#
if test "${dfb}" = "yes" ; then
echo -n "Checking for libcle266mpegdec ... "
- cle266_cflags=`PKG_CONFIG_PATH=$PKG_CONFIG_PATH pkg-config --cflags
libcle266mpegdec 2>>config.log` || cle266="no"
+ pkg-config --atleast-version=0.2 libcle266mpegdec 2>>config.log ||
cle266="no"
if test "${cle266}" = "yes" ; then
+ cle266_cflags=`PKG_CONFIG_PATH=$PKG_CONFIG_PATH pkg-config --cflags
libcle266mpegdec`
cle266_libs=`PKG_CONFIG_PATH=$PKG_CONFIG_PATH pkg-config --libs
libcle266mpegdec`
cle266_opts="${cle266_cflags} ${cle266_libs}"
- fi
-
- if test "${cle266}" = "yes" ; then
echo "Enabled cle266 hardware decoding."
else
echo "Not found, not supported by DirectFB or disabled by argument."
fi
-else
- cle266="no"
fi
#########################################################
Index: mpeg2decoder.c
===================================================================
RCS file: /cvsroot/softdevice/softdevice/mpeg2decoder.c,v
retrieving revision 1.67
diff -u -r1.67 mpeg2decoder.c
--- mpeg2decoder.c 16 Sep 2006 09:30:19 -0000 1.67
+++ mpeg2decoder.c 16 Sep 2006 19:43:58 -0000
@@ -757,7 +757,7 @@
};
#ifdef HAVE_CLE266_MPEG_DECODER
-float aspect_ratio_values[5]={1.0, 1.0, 4.0/3.0, 16.0/9.0, 221.0/110 };
+float aspect_ratio_values[5]={1.0, 1.0, 4.0/3.0, 16.0/9.0, 2.21 };
int cVideoStreamDecoder::DecodePicture_cle266(sPicBuffer *&pic,
int &got_picture,uint8_t *data, int length, int64_t pkt_pts) {
_______________________________________________
Softdevice-devel mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/softdevice-devel
