Hi, Le 29/01/2016 14:34, aslam a écrit : > > > Hi All,
First about this one http://softwarefactory-project.io/r/#/c/2617/1. Please have a look to my comment. And you should maybe in addition fix the pysflib unit tests in the same patch if needed. > Regarding my patch on using upstream pygerrit. I made some changes in > pysflib. But the install_pygerrit function in softwarefactory.install > (https://github.com/redhat-cip/software-factory/blob/17b1c5c2d62cfd5b8475815f86dc0426ee55a187/image/softwarefactory.install#L240) > uses the forked version. I am not sure how it falls into the picture. > This has to be also changed right (in another patch) ? After yes I think you can remove : https://github.com/redhat-cip/software-factory/blob/master/image/softwarefactory.install#L231-L238 and add pygerrit there: https://github.com/redhat-cip/software-factory/blob/master/image/packages/pip_pkgs.txt The pysflib requirements.txt is not used when we build the SF image. Instead we have now some global requirements in image/packages/. So pysflib will rely on the pygerrit version we define in pip_pkgs.txt. You can use Depends-on in the commit message of your changes if you need to tell Zuul to include other project changes when testing your patch. Maybe you will need to do some changes in managesf too in order to support the new pygerrit. It is possible at some places (few) managesf uses directly pygerrit instead of pysflib. > > Also I thought I would need to change the tests code here : > https://github.com/redhat-cip/pysflib/blob/028f7121feadd72d761d11f372caf19cfc324925/pysflib/tests/test_sfgerrit.py#L43. yep > However I didn't change anything. (I am not familiar with Mock testing, > learning on the way) > > But the functional tests passed locally. Any comments on the 2nd? > > > Regards, > Aslam > Regards Fabien > > _______________________________________________ > Softwarefactory-dev mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/softwarefactory-dev _______________________________________________ Softwarefactory-dev mailing list [email protected] https://www.redhat.com/mailman/listinfo/softwarefactory-dev
