Hi,
On Mon 30 Oct 2017 16:12, [email protected] writes:
> Title : A YANG Data Model for IPv4-in-IPv6 Address plus
> Port Softwires
> Authors : Qi Sun
> Hao Wang
> Yong Cui
> Ian Farrer
> Sladjana Zechlin
> Mohamed Boucadair
> Rajiv Asati
> Filename : draft-ietf-softwire-yang-02.txt
> Pages : 41
> Date : 2017-10-30
I had a look at this for the Snabb lwAFTR and found a few issues.
1. "hairpin-ipv4-packets" and "hairpin-ipv4-bytes" need to be state
data, not config data. Consider moving them inside the
"traffic-stat" container.
2. "dropped-ipv4-bytes", described as counting bytes from dropped IPv4
fragments, should probably be named "dropped-ipv4-fragment-bytes" or
something. Note there is already "dropped-ipv4-byte" (sic) for
dropped IPv4 bytes as a whole.
3. "dropped-ipv4-bytes" (from (2)), "dropped-ipv4-fragments",
"hairpin-ipv4-packets" (from (1)), and "hairpin-ipv4-bytes" (from
(1)) are plural whereas the rest of the counters are singular. One
or the other should probably be chosen.
4. The type of "icmpv6-errors-rate" is "uint16". This is probably too
restrictive.
Regards,
Andy
_______________________________________________
Softwires mailing list
[email protected]
https://www.ietf.org/mailman/listinfo/softwires
