Sorry to paste a bunch of code in here but I want to pass in order to make the
updateable IndexReader work, I need to pass in the existing IndexSearcher into
the new SolrIndexSearcher, however currently the existing SolrIndexSearcher is
obtained after in the code. The locking and referencing is a little bit
complex and looks like it can easily be screwed up. Any hints from Solr dev
team on how to pass the existing into the SolrIndexSearcher?
Thanks,
Jason
-----------------------------------------
from: SolrCore
// open the index synchronously
// if this fails, we need to decrement onDeckSearchers again.
SolrIndexSearcher tmp;
try {
if (onDeckSearchers < 1) {
// should never happen... just a sanity check
log.severe("ERROR!!! onDeckSearchers is " + onDeckSearchers);
// reset to 1 (don't bother synchronizing)
onDeckSearchers=1;
} else if (onDeckSearchers > 1) {
log.info("PERFORMANCE WARNING: Overlapping onDeckSearchers=" +
onDeckSearchers);
}
// ******* want to pass existing here
tmp = new SolrIndexSearcher(schema, "main", index_path, true, );
} catch (Throwable th) {
synchronized(searcherLock) {
onDeckSearchers--;
// notify another waiter to continue... it may succeed
// and wake any others.
searcherLock.notify();
}
// need to close the searcher here??? we shouldn't have to.
throw new RuntimeException(th);
}
final SolrIndexSearcher newSearcher=tmp;
RefCounted<SolrIndexSearcher> currSearcherHolder=null;
final RefCounted<SolrIndexSearcher> newSearchHolder=newHolder(newSearcher);
if (returnSearcher) newSearchHolder.incref();
// a signal to decrement onDeckSearchers if something goes wrong.
final boolean[] decrementOnDeckCount=new boolean[1];
decrementOnDeckCount[0]=true;
try {
synchronized (searcherLock) {
if (_searcher == null) {
// if there isn't a current searcher then register this one
// before warming is complete instead of waiting.
registerSearcher(newSearchHolder);
decrementOnDeckCount[0]=false;
} else {
// get a reference to the current searcher for purposes of
autowarming.
currSearcherHolder=_searcher;
currSearcherHolder.incref();
}
}
// ******* currently obtained here
final SolrIndexSearcher currSearcher = currSearcherHolder==null ? null :
currSearcherHolder.get();
