Hi Darren,
I'm a bit confused about the meaning of hasExplicitField...
If I have a <copyField source="*_a" dest="*_b"/>
The dynamic fields *_a and *_b must both be defined, right?
In that case, it seems like "if it matches a field or dynamicField
declaration" would always be true, no?
+ /**
+ * Does the schema have the specified field defined explicitly, i.e.
+ * not as a result of a copyField declaration with a wildcard? We
+ * consider it explicitly defined if it matches a field or dynamicField
+ * declaration.
+ * @param fieldName
+ * @return true if explicitly declared in the schema.
+ */
+ public boolean hasExplicitField(String fieldName) {
+ if(fields.containsKey(fieldName)) {
+ return true;
+ }
+
+ for (DynamicField df : dynamicFields) {
+ if (df.matches(fieldName)) return true;
+ }
+
+ return false;
+ }
-Yonik
On 6/6/06, Yonik Seeley <[EMAIL PROTECTED]> wrote:
Thanks Darren!
I'm looking it over now.
-Yonik
On 6/6/06, Darren Erik Vengroff (JIRA) <[EMAIL PROTECTED]> wrote:
> Dynamic copying of fields (allow wildcard sources in copyField)
> ---------------------------------------------------------------
>
> Key: SOLR-21
> URL: http://issues.apache.org/jira/browse/SOLR-21
> Project: Solr
> Type: New Feature
>
> Components: update
> Environment: all
> Reporter: Darren Erik Vengroff
> Attachments: dynamicCopy.patch
>
> It would be really nice if it were possible to use wildcards to do things
like:
>
> <copyField source="*_t" dest="text"/>
>
> The above example copies all fields ending in "_t" to the "text" field.
>
> I've put together a patch to do this. If there are mutlitple matches, all
copies are done. If there is a match in a dynamicField, then the dynamic field is
also generated, subject to the existing rules that short expressions go first. I
tried to stick to the spirit of the code as I saw it, and made what I thought were
a minimal reasonable set of changes. The patch includes some additional tests in
ConvertedLegacyTest.java to test the new functionality. That may not be the best
place for new tests, but it beats no tests.
>
> I'd really like to get this, or some improved variant of it into the
codebase, as it's quite important to my application. Please review and
comment/criticize as you see fit.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators:
> http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
> http://www.atlassian.com/software/jira
