: Are there any objections to replacing BitSet with OpenBitSet in BitDocSet?
: http://issues.apache.org/jira/browse/SOLR-15
+1
... but I'd feel better about it if there were static utility methods
for converting from BitSet<=>OpenBitSet so that BitDocSet could continue
to have deprecated constructors that take in a BitSet (and could continue
to impliment getBits():BitSet)
Those should be fairly straight forward right? ...
public static BitSet convert(final OpenBitSet in) {
final BitSet out = new BitSet(in.length());
for(int i=in.nextSetBit(0); i>=0; i=in.nextSetBit(i+1)) {
out.set(i);
}
return out;
}
(were you planing on changing the declaration of DocSet.getBits() to
return OpenBitSet?)
My only other question about the code in SOLR-15 was wether or not some of
those low level utilities like "pop_xor(long[],long[],int,int):long"
should be protected/private?
-Hoss
