[
http://issues.apache.org/jira/browse/SOLR-35?page=comments#action_12422198 ]
Yonik Seeley commented on SOLR-35:
----------------------------------
Thanks Phil,
Please don't make formatting changes in patches that make other changes
though... it makes it very hard to see what has changed.
Here is what it looks like these patches do:
- admin JSP pages: changes charset
- adds a space between the mime-type and charset
Example: "text/xml;charset=UTF-8" => "text/xml; charset=UTF-8"
Does this fix a bug, or is it just better style?
- when logging requests, replaces partialURLEncodeVal with URLEncoder.encode()
one reason I didn't use this originally was that I wanted queries easier to
read... encode() is both slower and encodes many things that don't need to be
encoded.
I would much rather see q=title:"solr+search" in the log, not
q=%22title%3Asolr%20search%22
> URL escaping problems in webapp
> -------------------------------
>
> Key: SOLR-35
> URL: http://issues.apache.org/jira/browse/SOLR-35
> Project: Solr
> Issue Type: Bug
> Components: search
> Environment: Darwin berlin.local 8.7.1 Darwin Kernel Version 8.7.1:
> Wed Jun 7 16:19:56 PDT 2006; root:xnu-792.9.72.obj~2/RELEASE_I386 i386 i386
> Reporter: Philip Jacob
> Attachments: patch-utf-8-problems-webapp.patch,
> patch-utf-8-problems.patch
>
>
> Tricia Williams reported problems with Cyrillic charsets when trying to
> search using the admin application, specifically NPEs and bad results.
> This patch fixes the webapp by specifying a character encoding for each of
> the admin pages.
> I also discovered a second issue in StrUtils that wasn't encoding UTF-8 data
> properly, so I fixed that. I'm attaching 2 patches.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
