: This perfectly fits my needs, but has one problem.  Since the
: requestHandler flags are not passed through, XMLWriter throws a
: NullPointerException when it encounters iterator.score() when trying
: to write out a results.docList with scores.  Adding the flags argument

Really??  ... that's weird ... can you open a Jira bug with a test case
demonstrating this -- The XMLWriter should be able to output any DocList
regardless of wether it has scores or not (that's what the
DocList.hasScorers()  method is for as I recall ... but I don't have the
code in front of my right now to try a test.

: to the getDocListAndSet methods in SolrIndexSearcher appears to solve
: that problem, i.e.:
        ...
: as well as adding the flags argument to the other getDocListAndSet
: method, so that the requestHandler flags are passed through.  Is there
: a performance or other reason that flags are not present in the
: getDocListAndSet signatures, as opposed to the getDocList, or should I
: submit this as a JIRA issue/patch?

i actually never noticed that getDocListAndSet methods don't take a flags
param -- I can't think of any reason why they shouldn't, but to minimize
the API changes we may want to add one new varient instead of modifying
all three of existing signatures.  I'm sure a patch to do that would
be appreciated.


-Hoss

Reply via email to