+1 I think it should be optional, default to off, and the request parameters should be in the header. One advantage of having it in the header is that this information can be used by the clinet to process the query responses as they are being read.
Bill On 10/24/06, Chris Hostetter <[EMAIL PROTECTED]> wrote:
Acctually ... i revise my previous statment ... if we are talking about just the explicit params that come from the client in the request (the same that get written to the log) then i suppose letting SolrCore put them in the response makes sense ... in which case putting them in the header is right thing to do ... this seems like the most important use case because it's what is neccessary for the client to recreate the given request (someone made the point that defaults can change, that may be true, but the code implimenting the request handler could change just as easily -- nothing we do can 100% garuntee that the user gets hte same behavior). The other cases: logging the "effective" params, what the plugin ultimately wound up using after default and invarient params might get applied ... that's a complicated issue in my mind .. i think if people wnat that functionality in their RequestHandlers that's up to them ... i don't know if it's a good idea for standard or dismax to include them. : I think it should be done by the RequestHandlers, using shared utility : methods to make it easy, and thus should go in the response body -- not : hte header. : : the header should be kept small, containing only core low level info about : the status of the communication with SolrCore. -Hoss
