[
http://issues.apache.org/jira/browse/SOLR-79?page=comments#action_12457536 ]
Hoss Man commented on SOLR-79:
------------------------------
1) i'm not really a fan of the Jetty syntax ... much too verbose for my taste,
I would prefer ${system.prop} over {$system.prop} to be consistent with ant and
shell variables ... but it would be nice to still support defaults ... isn't
${prop.name:default val} what bash uses?
2) to be useful, wouldn't we want this to work even if the property wasn't the
full value of the tag, ie...
<listener event="postCommit" class="solr.RunExecutableListener">
<str name="exe">snapshooter</str>
<str name="dir">${some.dir.property}/bin</str>
<bool name="wait">true</bool>
</listener>
...if we do this, we should also have some sort of escaping mechanism for
completleness, is <tag>$${some.prop}</tag> would not get substitution.
3) not everything uses Config.getVal ... we would also need similar
substitution logic in Config.evaluate, Config.getNode, and the various DOMUtil
methods so that it could be used *anywhere* in the solrconfig.xml ... walking
all of the NodeTrees to make the substitutions at every level, might get
complicated ... maybe there is an easier way of adding a "visiter" to the DOM
model?
> [PATCH] Using system properties in Solr configuration
> -----------------------------------------------------
>
> Key: SOLR-79
> URL: http://issues.apache.org/jira/browse/SOLR-79
> Project: Solr
> Issue Type: New Feature
> Reporter: Alexander Saar
> Priority: Minor
> Attachments: solr-config-system-property.patch,
> solr-config-system-property.patch
>
>
> Actually it is not possible to use system properties for configuring the Solr
> engine. There should be a way of referencing system properties from
> solrconfig.xml, like {$prop.name}.
> The attached patch will provide this feature.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
