[ http://issues.apache.org/jira/browse/SOLR-78?page=comments#action_12458600 ] Yonik Seeley commented on SOLR-78: ----------------------------------
I'm no DOM expert, but it looks OK. If it works on all our current tests/configs then it's a low risk change since that's all it's used for. Hmmm, but *how* do we know it's reading all the values OK, instead of getting a default or something. Perhaps run a startup test with the debugging level pumped all the way up, one before the change, and one after, then diff the logs (minus timestamps/linenumbers)? Oh, and StringBuffer could be StringBuilder, but it's private so I don't really care. > [PATCH] Improved config loading > ------------------------------- > > Key: SOLR-78 > URL: http://issues.apache.org/jira/browse/SOLR-78 > Project: Solr > Issue Type: Improvement > Reporter: Alexander Saar > Assigned To: Hoss Man > Priority: Minor > Attachments: fixed-config-loading-with-older-parser-versions.patch, > fixed-config-loading-with-older-parser-versions.patch > > > Solr configuration throws an UnsupportedConfigurationException for > Node.getTextContent() if it is started in server environments that uses older > implementations of the DOM API. This can be improved by checking wich node > type is actually handled an calling the appropriate methods. > A patch that fixes this problem is attached. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
