[
https://issues.apache.org/jira/browse/SOLR-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12468158
]
Coda Hale commented on SOLR-122:
--------------------------------
I'll see if I can't get some better benchmarks for this -- there's no good
reason why this drop-in would improve querying times.
Also, I'm not sure what you mean by "your Xml class." The drop-in doesn't add
any additional classes; it just opens up the existing ones and modifies their
XML behavior to use libxml-ruby instead of REXML. And the drop-in isn't loaded
by default, so there's no worry of it not working with someone who doesn't have
libxml-ruby installed. They'd have to go out of their way (i.e., require
"solrb/libxml") to shoot themselves in the foot.
Let me know when you refactor this; I'm fine with re-writing it.
> Add optional support for Ruby-libxml2 (vs. REXML)
> -------------------------------------------------
>
> Key: SOLR-122
> URL: https://issues.apache.org/jira/browse/SOLR-122
> Project: Solr
> Issue Type: Improvement
> Components: clients - ruby - flare
> Reporter: Coda Hale
> Attachments: libxml.rb, libxml.rb
>
>
> This file adds drop-in support for the ruby-libxml2, which is a wrapper for
> the libxml2 library, which is an order of magnitude or so faster than REXML.
> This depends on my SOLR-121 patch for multi-document adds, since the behavior
> of Solr::Request::AddDocument#to_s is different.
> Requiring this makes some tests fail, but for trivial reasons: some tests are
> directly tied to REXML, others fail due to interelement whitespace added by
> libxml2 (which you can't disable via the Ruby interface). Functionally, it's
> identical, and passes all functional tests.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
