[ 
https://issues.apache.org/jira/browse/SOLR-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12474310
 ] 

Hoss Man commented on SOLR-166:
-------------------------------

hmmm ... servlet spec 2.4 says that all fitlers should be loaded before any 
servlets (see p78 in SRV.9.12) ... so unless that's changed between 2.3 nad 2.4 
it's a resin bug.

Ryan: one thing to try is changing the web.xml to use the 2.4 XSD instead of 
the 2.3 DTD and see if that forces resin to be compliant about loading the 
filter first.

in general, i think it's good to load Servlets on startup even if there is no 
special initialization code they need to run, because it helps validate that 
the servlet is there on startup, and reduces the request time for the "first 
request" to that servlet because the class is alrready loaded.

a third option you didn't mention would be moving all of the setInstanceDir 
logic using JNDI from the SolrDispatchFilter into Config.getInstanceDir ... off 
the top of my head i'm not sure why it was ever in the Dispatcher/SolrServlet 
in the first place.

In a nutshell, getInstanceDir should check if a dir has been set, if not try 
JNDI, then system prop, then default to CWD and call setInstanceDir.


what do you think?

> trunk requires solr.solr.home set even if JNDI is set
> -----------------------------------------------------
>
>                 Key: SOLR-166
>                 URL: https://issues.apache.org/jira/browse/SOLR-166
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: Ryan McKinley
>
> The current trunk requires the solr.solr.home property to be set - even if 
> JNDI is configured properly.  
> I think this is because SolrServlet loads before SolrDispatchFilter and calls 
> SolrCore.getSolrCore();
> is there a way to make sure SolrDispatchFilter gets initalized first?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to