On Apr 27, 2007, at 4:45 PM, Yonik Seeley wrote:
Off on a tangent: for contributors, we want to be careful about
implying that patches should always be complete, include unit tests,
and be documented. While it's nice, we'd still rather have a patch
than no patch at all.
Of course if someone is looking to become a committer, then we would
be looking at patch completeness, quality, tests, etc.
+1 on Yonik's comments!
And this is where we committers can really lend a hand in mentoring
contributors, by creating or beefing up unit tests for contributed
patches and showing others how to run and craft the tests.
Here's a tip: contributors can start with a clean checkout, ensure
unit tests pass, then apply their changes and ensure the existing
tests still work.
Erik
