[
https://issues.apache.org/jira/browse/SOLR-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495209
]
Ryan McKinley commented on SOLR-234:
------------------------------------
>
> .. a Filter can't make any assumptions about source of the tokens except the
> token itself ...
I get the basic pattern now: Tokenizers determin the start/end offsets and
Filters just transform the text along the way.
> In Ryan's use case he may want his highlighter-esque code to be able to know
> ...
>
I am fine with either:
1. leave the TrimFilter as is and do the highlighter-esque code on the
highlighting side.
2. Add an optional updateOffsets="true" param, with the default set to "false"
> TrimFilter should update the start and end offsets
> --------------------------------------------------
>
> Key: SOLR-234
> URL: https://issues.apache.org/jira/browse/SOLR-234
> Project: Solr
> Issue Type: Improvement
> Reporter: Ryan McKinley
> Priority: Minor
> Attachments: SOLR-234-TrimFilterOffsets.patch,
> SOLR-234-TrimFilterOffsets.patch
>
>
> As implemented, the TrimFilter only trims the text. It does not update the
> the startOffset and endOffset
> see:
> http://www.nabble.com/TrimFilter----t.startOffset%28%29%2C-t.endOffset%28%29-tf3728875.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
