[ 
https://issues.apache.org/jira/browse/SOLR-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501063
 ] 

Hoss Man commented on SOLR-253:
-------------------------------

the first thing i thought when reading the description of this issue was that 
it seemed like a strnage bastardization of the StopFilter class ... looking at 
the patch i see it's not even implemented in the StopFilter - it's a new 
"GoFilter" class which makes me feel a lot better.

I'd rather see a new "GoFilterFactory" class be added then to have a 
conditional switch in StopFilterFactory ... people skimming a schema may not 
notice a requireWord boolean on a StopFilterFactory declaration that completely 
reverses the meaning of the declaration ... it would be better to make it more 
obvious.

> Optionally use the StopFilterFactory to only include words in the set
> ---------------------------------------------------------------------
>
>                 Key: SOLR-253
>                 URL: https://issues.apache.org/jira/browse/SOLR-253
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan McKinley
>            Priority: Minor
>         Attachments: SOLR-253-RequireWords.patch
>
>
> Use the StopFilterFactory to generate the inverse filter: one that only keeps 
> tokes if it is in the list.
> This patch adds "requiteWord" to the possible args:
>  <filter class="solr.StopFilterFactory" ignoreCase="true" 
> words="stopwords.txt" requiteWord="true"/>

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to