[
https://issues.apache.org/jira/browse/SOLR-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12501725
]
Ryan McKinley commented on SOLR-143:
------------------------------------
>
> Ryan, i haven't looked at your updated patch, but i don't understand your
> last comment...
>
There is nothing interisting in the changes, it just does not conflict with the
recently added init-forrest-entities
The patch also removes your attempts to fix the PMD serious errors (4 months
later, most of the .java files have conflict) We should probalby fix them when
this does get added.
>> Is there a reason to have the -Drun.clover configuration rather then the
>> target specifying if clover is used or not?
>
> how would that work exactly? the run.clover property is what's used to
> ensure that code is compiled with clover hooks (in the existing "compile"
> target) and that the clover db is initialized prior to running the unit tests
> (in the existing "test" target).
>
magic!
I just looked into other projects I thought did this - they have different
'compile' tasks for test and dist and require everyone to have clover. This is
not appropriate for solr, so the -Drun.clover option is better.
> Support for PMD and Clover
> --------------------------
>
> Key: SOLR-143
> URL: https://issues.apache.org/jira/browse/SOLR-143
> Project: Solr
> Issue Type: Improvement
> Reporter: Hoss Man
> Priority: Minor
> Attachments: pmd-and-clover.diff, SOLR-143-CloverAndPMD.patch
>
>
> had some time on a plane this weekend, so I adapted some of the clover hooks
> from Java-Lucene to Solr's build.xml and also put in hooks for running PMD (a
> bug pattern finding tool).
> the PMD hook actually teste the PMD ruleset twice, once warning about any
> violations, and once failing the build if any serious violations were found
> ... the goal would be to hook this into the "ant test" target so you can't
> successfully build if you have any serious rule violations.
> i strarted with a custom ruleset based on some of the bigger rules from PMD
> ... the theory being that as well clean up the code base we can add more
> nit-picky rules if we want to :)
> User is required to provide their own copy of PMD and/or clover on in an
> ANT_LIB. Clover requires (ASF committer) license, PMD is freely available...
> http://pmd.sourceforge.net/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
