Yes, I think I mentioned the same thing in one of my comments, I think in SOLR-255. Smaller ==> easier to understand ==> less potential breakage ==> less risk to commit ==> commit! :)
Otis . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . Simpy -- http://www.simpy.com/ - Tag - Search - Share ----- Original Message ---- From: Mike Klaas <[EMAIL PROTECTED]> To: [email protected] Sent: Saturday, June 23, 2007 1:45:13 AM Subject: Re: [jira] Commented: (SOLR-255) RemoteSearchable for Solr(use RMI) On 22-Jun-07, at 6:53 AM, Henri Biestro (JIRA) wrote: > > [ https://issues.apache.org/jira/browse/SOLR-255? > page=com.atlassian.jira.plugin.system.issuetabpanels:comment- > tabpanel#action_12507326 ] > > Henri Biestro commented on SOLR-255: > ------------------------------------ > > Toru, > I've been looking quickly at your patch and kinda understands why > Otis is pushing for a merge. :-) > I dont know how this is usually done; should we merge the 2 issues > and merge our patches? > I can try & see how this goes if you want. > > One thing that worries me though is the Lucene patch dependency; > any way to only have a Solr patch? > I would suspect that Lucene committers are as busy as Solr 's so > the review process might take sometime. > Although from far, it does look like pretty harmless changes so > there is hope... > > As a side note, I was wondering if we could extend you patch's > functionality and get read/write capability per index (as in http:// > hellonline.com/blog/?p=55 ,document indexing load balancing could > be performed on hashing unique key % number of indexes for instance > or by some configurable class). The current functionality would be > retained by specificying 'read-only' versus 'read-write' for each > index. I just wanted to note (in midst of all this talk of merging patches and adding functionality), that the larger a patch becomes, the harder it is to evaluate and maintain. It might be better to split it up in terms of dependencies: one patch depends on the other. Or, if the core infrastructure is similar/highly dependent, split it up into a core patch and outward-facing-feature patch. -Mike
