[ 
https://issues.apache.org/jira/browse/SOLR-256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507998
 ] 

Hoss Man commented on SOLR-256:
-------------------------------

> Instead of starting its own, other alternative (as you have pointed out) 
> could be to use platform registry itself. In that > case:
> MBeanServer mbs = ManagementFactory.getPlatformMBeanServer(); 

that seems like the way to go.

 the one thing i'm not clear on is if there is simple  programmaticly way to 
tell when JMX monitoring is already enabled so we can still do the check you 
have in the static block and only use the JMXified impls if we need them (i'm 
assuming you put that in because there is some overhead we want to avoid if JMX 
is not needed)

the javadocs for ManagementFactory.getPlatformMBeanServer() indicate that it 
creates on first use ... so testing that won't work ... we could test for the 
system properties ourselves, but i *think* servlet containers like jetty and 
tomcat have their own config file syntax for enabling JMX and then call the 
neccessary underlying methods , so just becuase those properties aren't set 
doesn't neccessarily mean anything right?

do you know if my guess about servlet containers programmaticly turning JMX on 
even without the standard system properties being set is true? do you have any 
suggestions on how to deal with this?  

> Stats via JMX
> -------------
>
>                 Key: SOLR-256
>                 URL: https://issues.apache.org/jira/browse/SOLR-256
>             Project: Solr
>          Issue Type: New Feature
>          Components: search, update
>            Reporter: Sharad Agarwal
>            Priority: Minor
>         Attachments: jmx.patch, jmx.patch, jmx.patch
>
>
> This patch adds JMX capability to get statistics from all the SolrInfoMBean.
> The implementation is done such a way to minimize code changes. 
> In SolrInfoRegistry, I have overloaded Map's  put and remove methods to 
> register and unregister SolrInfoMBean in MBeanServer. 
> Later on, I am planning to use register and unregister methods in 
> SolrInfoRegistry and removing getRegistry() method (Hiding the map instance 
> to other classes)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to