[
https://issues.apache.org/jira/browse/SOLR-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12509709
]
Mike Klaas edited comment on SOLR-225 at 7/2/07 4:14 PM:
---------------------------------------------------------
Looking great Ryan (again, only commenting on the Highlighting configurability
parts)
should:
protected boolean emptyArray(String[] arr) {
return (arr == null || arr.length == 0 || arr[0] == null ||
arr[0].trim().length() == 0);
}
perhaps be defined as
protected boolean emptyArray(String[] arr) {
return (arr == null || arr.length == 0 ||
(arr.length == 1 && (arr[0] == null || arr[0].trim().length()
== 0)));
}
Params:
+ public static final String HIGHLIGHT = "hl";
+ public static final String PREFIX = "hl.";
+ public static final String FIELDS = PREFIX+"fl";
+ public static final String SNIPPETS = PREFIX+"snippets";
+ public static final String FRAGSIZE = PREFIX+"fragsize";
+ public static final String INCREMENT = PREFIX+"increment";
+ public static final String SLOP = PREFIX+"slop";
perhaps this should be PREFIX + 'regex.slop'?
+ public static final String MAX_CHARS = PREFIX+"maxAnalyzedChars";
similarly. Seems somewhat inelegant to define/hardcode the plugin-specific
parameters here, though it is nice ot have them all in one place...
was:
Looking great Ryan (again, only commenting on the Highlighting configurability
parts)
should:
protected boolean emptyArray(String[] arr) {
return (arr == null || arr.length == 0 || arr[0] == null ||
arr[0].trim().length() == 0);
}
perhaps be defined as
protected boolean emptyArray(String[] arr) {
return (arr == null || arr.length == 0 || arr.length == 1arr[0] == null ||
arr[0].trim().length() == 0);
}
> Allow pluggable Highlighting classes -- Formatters and Fragmenters
> ------------------------------------------------------------------
>
> Key: SOLR-225
> URL: https://issues.apache.org/jira/browse/SOLR-225
> Project: Solr
> Issue Type: Improvement
> Reporter: Brian Whitman
> Assignee: Ryan McKinley
> Attachments: SOLR-225+260-HighlightPlugins.patch,
> SOLR-225+260-HighlightPlugins.patch, SOLR-225-HighlightingConfig.patch,
> SOLR-225-HighlightingConfig.patch, SOLR-225-HighlightingConfig.patch,
> SOLR-225-HighlightingConfig.patch, SOLR-225-HighlightingConfig.patch
>
>
> Highlighting should support a pluggable architecture similar to what is seen
> with RequestHandlers, Fields, FieldTypes, etc
> '
> For more background:
> http://www.nabble.com/Custom-fragmenter-tf3681588.html#a10289335
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
