[ 
https://issues.apache.org/jira/browse/SOLR-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12526224
 ] 

Ryan McKinley commented on SOLR-352:
------------------------------------

did you apply the whole patch?

It includes a null check at line 59 of ClientUtils.java.


//--------------------------------------------------------------------------
Index: client/java/solrj/src/org/apache/solr/client/solrj/util/ClientUtils.java
===================================================================
--- client/java/solrj/src/org/apache/solr/client/solrj/util/ClientUtils.java    
(revision 574315)
+++ client/java/solrj/src/org/apache/solr/client/solrj/util/ClientUtils.java    
(working copy)
@@ -56,9 +56,12 @@
    */
   public static Collection<ContentStream> toContentStreams( final String str, 
final String contentType )
   {
+    if( str == null )
+      return null;
+
+    ArrayList<ContentStream> streams = new ArrayList<ContentStream>( 1 );
     ContentStreamBase ccc = new ContentStreamBase.StringStream( str );
     ccc.setContentType( contentType );
-    ArrayList<ContentStream> streams = new ArrayList<ContentStream>();
     streams.add( ccc );
     return streams;
   } 

> UpdateRequest is duplicating commit and optimize requests
> ---------------------------------------------------------
>
>                 Key: SOLR-352
>                 URL: https://issues.apache.org/jira/browse/SOLR-352
>             Project: Solr
>          Issue Type: Bug
>          Components: clients - java
>    Affects Versions: 1.3
>            Reporter: Bill Au
>            Assignee: Bill Au
>            Priority: Minor
>         Attachments: solr-352.patch, solr-352.patch
>
>
> UpdateRequest current sets both query args and a update XML message in the 
> POST body.  This causes Solr to do two commit/optimize for each 
> commit/optimize request sent in by SolrJ.  I will be attaching a patch to 
> remove the commit/optimize query args.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to