On 10/25/07, Chris Hostetter <[EMAIL PROTECTED]> wrote: > : I'm working on a request handler pluging that needs to use a DocSet filter > : (for distance limiting) as well as a list of filter queries to filter down a > : search. I'm trying to figure out how to best pass that to the > : SolrIndexSearcher. > > how did you build up the DocSet? ... typically a DocSet comes from a > Query, and you would just add that query to the other list and let > getDocList take care of building the DocSet from it.
Yeah... keep in mind that one can't get query caching with DocSet filters, only with the symbolic Query filters. > : convert the filterList to a DocSet and intersect it with the filter, but the > : method that does that well getDocSet(List<Query> queries) is protected > > thta looks like it may have been because yonik wasn't certain that he > wanted to keep it when he first added it ... Yeah, I was sick of adding new variants of public methods only to discover later that I wished it had more info or that I had done it differently :-) So I could see some in the future wanting getDocSet(List<Query> intersect, List<Query> not, List<DocSet> intersect, List<DocSet> not, etc...) But I'm not against promoting the current method to public. > : Also, it looks that the getDocListC method, which takes both filter and > : filterList, actually uses both if it decides to use the filterCache, but > : only uses one of the two if it takes the else block. Is that by design? > > this is why even private should have javadocs .. i believe it is only > legal to call this method with *either* a DocSet or a List<Query> .. not > both (Yonik: can you confirm?) Correct... I'll make a comment. -Yonik
