[ 
https://issues.apache.org/jira/browse/SOLR-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12537958
 ] 

Scott Tabar commented on SOLR-395:
----------------------------------

I will be making changes to SOLR-375 to display the frequency for the word that 
is being checked instead of using the boolean exists.  This should not be 
conditional by a parameter, but should be part of the default results as is the 
exists modification currently has been implemented.

It would not be a problem to incorporate these changes in to JIRA-375 and also 
for me to add additional unit tests to cover the frequency modifications.

Mike (both), do you have any other suggestions to enhance the 
SpellCheckerRequestHandler?

Not running this code, but just reviewing the patch, it appears like the 
frequency list is parallel and separate to the suggestion list.  This is great 
from the perspective of backwards compatibility, but would it make more sense 
to alter the suggestion list's data structure to make a stronger tie or 
relationship to the word that is be suggested?  Right now only the frequency is 
of interest, but if additional information can be provided, say the value of 
"distance", then there would be a logical place for it, otherwise we would have 
yet another "list" of "values".  Having an organized data structure could be 
more conducive to using Java's "for each" or Prototype's "each" construct 
without needing to track index values in to one array or the other.  I realize 
this may be more a matter of preference on style, but nows the time to make a 
change if it is so desired. 

One idea of integrating the frequency of the suggestion is to make the 
frequency an attribute on the <str> tag such as <str 
frequency="1283">happy</str>.  This may help with backwards compatibility but 
there is not much support for the addition of attributes within Solr so that 
could prevent its use. 



> Spell-check should return frequencies of word and suggestions
> -------------------------------------------------------------
>
>                 Key: SOLR-395
>                 URL: https://issues.apache.org/jira/browse/SOLR-395
>             Project: Solr
>          Issue Type: Improvement
>          Components: spellchecker
>    Affects Versions: 1.3
>            Reporter: Mike Krimerman
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: returnFrequencies.patch
>
>
> When issuing a spell-check, the word being searched for might be present in 
> the index with a very low frequency (i.e. a misspelling that made it's way 
> into the index). It might therefore be helpful if the client receives the 
> frequency of the word plus the frequencies of each of the suggestions.
> This feature should be optional (using a URL param).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to