[ 
https://issues.apache.org/jira/browse/SOLR-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12556944#action_12556944
 ] 

Sean Timm commented on SOLR-303:
--------------------------------

I'm receiving both patch errors and compile errors from Yonik's latest patch 
(03/Jan/08) against head on the trunk (r. 610010).  I ignore the errors on the 
two Test files.  It fails to remove the handler/SearchHandler.java
{noformat}
% patch -p0 -u < ~/distributed.patch
[...]
patching file src/java/org/apache/solr/handler/SearchHandler.java
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n] y
Hunk #1 FAILED at 1.
File src/java/org/apache/solr/handler/SearchHandler.java is not empty after 
patch, as expected
1 out of 1 hunk FAILED -- saving rejects to file 
src/java/org/apache/solr/handler/SearchHandler.java.rej
{noformat}

After removing handler/SearchHandler.java, the build errors that I am getting 
are:
{noformat}
% ant compile
Buildfile: build.xml

init-forrest-entities:

compile-common:

compile:
    [javac] Compiling 84 source files to 
/home/timmsc/svn.apache.org/lucene/solr/trunk/build/core
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:303:
 'class' or 'interface' expected
    [javac] package org.apache.solr.handler.component;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:305:
 'class' or 'interface' expected
    [javac] import org.apache.solr.handler.RequestHandlerBase;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:306:
 'class' or 'interface' expected
    [javac] import org.apache.solr.common.util.NamedList;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:307:
 'class' or 'interface' expected
    [javac] import org.apache.solr.common.util.RTimer;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:308:
 'class' or 'interface' expected
    [javac] import org.apache.solr.common.util.SimpleOrderedMap;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:309:
 'class' or 'interface' expected
    [javac] import org.apache.solr.common.params.CommonParams;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:310:
 'class' or 'interface' expected
    [javac] import org.apache.solr.common.params.ModifiableSolrParams;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:311:
 'class' or 'interface' expected
    [javac] import org.apache.solr.common.SolrException;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:312:
 'class' or 'interface' expected
    [javac] import org.apache.solr.request.SolrQueryRequest;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:313:
 'class' or 'interface' expected
    [javac] import org.apache.solr.request.SolrQueryResponse;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:314:
 'class' or 'interface' expected
    [javac] import org.apache.solr.client.solrj.SolrServer;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:315:
 'class' or 'interface' expected
    [javac] import org.apache.solr.client.solrj.impl.CommonsHttpSolrServer;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:316:
 'class' or 'interface' expected
    [javac] import org.apache.solr.util.plugin.SolrCoreAware;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:317:
 'class' or 'interface' expected
    [javac] import org.apache.solr.core.SolrCore;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:318:
 'class' or 'interface' expected
    [javac] import org.apache.lucene.queryParser.ParseException;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:320:
 'class' or 'interface' expected
    [javac] import java.util.logging.Logger;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:321:
 'class' or 'interface' expected
    [javac] import java.util.Collection;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:322:
 'class' or 'interface' expected
    [javac] import java.util.List;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:323:
 'class' or 'interface' expected
    [javac] import java.util.ArrayList;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/SearchHandler.java:324:
 'class' or 'interface' expected
    [javac] import java.util.LinkedList;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:273:
 'class' or 'interface' expected
    [javac] package org.apache.solr.handler.component;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:275:
 'class' or 'interface' expected
    [javac] import org.apache.lucene.search.SortComparatorSource;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:276:
 'class' or 'interface' expected
    [javac] import org.apache.lucene.search.SortField;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:277:
 'class' or 'interface' expected
    [javac] import org.apache.lucene.util.PriorityQueue;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:278:
 'class' or 'interface' expected
    [javac] import org.apache.solr.common.util.NamedList;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:279:
 'class' or 'interface' expected
    [javac] import org.apache.solr.search.MissingStringLastComparatorSource;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:281:
 'class' or 'interface' expected
    [javac] import java.text.Collator;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:282:
 'class' or 'interface' expected
    [javac] import java.util.Comparator;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:283:
 'class' or 'interface' expected
    [javac] import java.util.Locale;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:284:
 'class' or 'interface' expected
    [javac] import java.util.List;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardDoc.java:285:
 'class' or 'interface' expected
    [javac] import java.util.ArrayList;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardRequest.java:60:
 'class' or 'interface' expected
    [javac] package org.apache.solr.handler.component;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardRequest.java:62:
 'class' or 'interface' expected
    [javac] import org.apache.solr.client.solrj.response.QueryResponse;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardRequest.java:63:
 'class' or 'interface' expected
    [javac] import org.apache.solr.common.params.ModifiableSolrParams;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardRequest.java:65:
 'class' or 'interface' expected
    [javac] import java.util.ArrayList;
    [javac] ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/ShardRequest.java:66:
 'class' or 'interface' expected
    [javac] import java.util.List;
    [javac] ^
    [javac] 36 errors

BUILD FAILED
/home/timmsc/svn.apache.org/lucene/solr/trunk/build.xml:224: The following 
error occurred while executing this line:
/home/timmsc/svn.apache.org/lucene/solr/trunk/build.xml:110: Compile failed; 
see the compiler error output for details.

Total time: 1 second
{noformat}

A good number of the errors are because 3 of the files are duplicated inline 
after the patch.  After fixing this I still get 17 errors.
{noformat}
% ant compile
Buildfile: build.xml

init-forrest-entities:

compile-common:

compile:
    [javac] Compiling 84 source files to 
/home/timmsc/svn.apache.org/lucene/solr/trunk/build/core
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/DisMaxDebugComponent.java:45:
 cannot find symbol
    [javac] symbol  : constructor 
SearchComponent(org.apache.solr.handler.component.SearchHandler)
    [javac] location: class org.apache.solr.handler.component.SearchComponent
    [javac]     super(handler);
    [javac]     ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/DisMaxDebugComponent.java:51:
 method does not override a method from its superclass
    [javac]   @Override
    [javac]    ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/DisMaxQueryComponent.java:57:
 cannot find symbol
    [javac] symbol  : constructor 
QueryComponent(org.apache.solr.handler.component.SearchHandler)
    [javac] location: class org.apache.solr.handler.component.QueryComponent
    [javac]     super(handler);
    [javac]     ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/DisMaxQueryComponent.java:63:
 method does not override a method from its superclass
    [javac]   @Override
    [javac]    ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/DisMaxQueryComponent.java:204:
 cannot find symbol
    [javac] symbol  : method 
getSortSpec(org.apache.solr.request.SolrQueryRequest)
    [javac] location: class org.apache.solr.util.SolrPluginUtils
    [javac]     builder.setSortSpec(SolrPluginUtils.getSortSpec(req) );
    [javac]                                        ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/component/DisMaxResponseBuilder.java:37:
 cannot find symbol
    [javac] symbol  : constructor 
ResponseBuilder(org.apache.solr.request.SolrQueryRequest)
    [javac] location: class org.apache.solr.handler.component.ResponseBuilder
    [javac]     super(req);
    [javac]     ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/FedSearchComponent.java:64:
 cannot find symbol
    [javac] symbol  : constructor 
SearchComponent(org.apache.solr.handler.component.SearchHandler)
    [javac] location: class org.apache.solr.handler.component.SearchComponent
    [javac]     super(handler);
    [javac]     ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/FedSearchComponent.java:91:
 cannot find symbol
    [javac] symbol  : variable handler
    [javac] location: class 
org.apache.solr.handler.federated.component.FedSearchComponent
    [javac]     SolrCore.getSolrCore().execute(handler, localReq, response);
    [javac]                                    ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/AuxiliaryQPhaseComponent.java:83:
 cannot find symbol
    [javac] symbol  : variable request_HL_and_MLT_Info_InMainPhase
    [javac] location: class org.apache.solr.handler.component.ResponseBuilder
    [javac]     rspBuilder.request_HL_and_MLT_Info_InMainPhase = false;
    [javac]               ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/AuxiliaryQPhaseComponent.java:84:
 cannot find symbol
    [javac] symbol  : variable request_fields_InMainPhase
    [javac] location: class org.apache.solr.handler.component.ResponseBuilder
    [javac]     rspBuilder.request_fields_InMainPhase = false;
    [javac]               ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/AuxiliaryQPhaseComponent.java:88:
 cannot find symbol
    [javac] symbol  : method 
skipProcess(org.apache.solr.request.SolrQueryRequest,org.apache.solr.request.SolrQueryResponse)
    [javac] location: class 
org.apache.solr.handler.federated.component.FedSearchComponent
    [javac]     if(super.skipProcess(req, rsp) ||
    [javac]             ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/GlobalCollectionStatComponent.java:138:
 cannot find symbol
    [javac] symbol  : method 
skipProcess(org.apache.solr.request.SolrQueryRequest,org.apache.solr.request.SolrQueryResponse)
    [javac] location: class 
org.apache.solr.handler.federated.component.FedSearchComponent
    [javac]     if(super.skipProcess(req, rsp) ||
    [javac]             ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/GlobalCollectionStatComponent.java:195:
 cannot find symbol
    [javac] symbol  : variable extractedTerms
    [javac] location: class org.apache.solr.handler.component.ResponseBuilder
    [javac]     rspBuilder.extractedTerms = extractedTerms;
    [javac]               ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/GlobalCollectionStatComponent.java:205:
 cannot find symbol
    [javac] symbol  : variable extractedTerms
    [javac] location: class org.apache.solr.handler.component.ResponseBuilder
    [javac]     final Set<String> extractedTerms = rspBuilder.extractedTerms;
    [javac]                                                  ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/MainQPhaseComponent.java:74:
 cannot find symbol
    [javac] symbol  : method 
skipProcess(org.apache.solr.request.SolrQueryRequest,org.apache.solr.request.SolrQueryResponse)
    [javac] location: class 
org.apache.solr.handler.federated.component.FedSearchComponent
    [javac]     if(super.skipProcess(req, rsp) ||
    [javac]             ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/MainQPhaseComponent.java:208:
 cannot find symbol
    [javac] symbol  : variable request_fields_InMainPhase
    [javac] location: class org.apache.solr.handler.component.ResponseBuilder
    [javac]     if(rspBuilder.request_fields_InMainPhase){
    [javac]                  ^
    [javac] 
/home/timmsc/svn.apache.org/lucene/solr/trunk/src/java/org/apache/solr/handler/federated/component/MainQPhaseComponent.java:238:
 cannot find symbol
    [javac] symbol  : variable request_HL_and_MLT_Info_InMainPhase
    [javac] location: class org.apache.solr.handler.component.ResponseBuilder
    [javac]           rspBuilder.request_HL_and_MLT_Info_InMainPhase
    [javac]                     ^
    [javac] Note: Some input files use or override a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] Note: Some input files use unchecked or unsafe operations.
    [javac] Note: Recompile with -Xlint:unchecked for details.
    [javac] 17 errors

BUILD FAILED
/home/timmsc/svn.apache.org/lucene/solr/trunk/build.xml:224: The following 
error occurred while executing this line:
/home/timmsc/svn.apache.org/lucene/solr/trunk/build.xml:110: Compile failed; 
see the compiler error output for details.

Total time: 2 seconds
{noformat}

> Distributed Search over HTTP
> ----------------------------
>
>                 Key: SOLR-303
>                 URL: https://issues.apache.org/jira/browse/SOLR-303
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>            Reporter: Sharad Agarwal
>            Assignee: Yonik Seeley
>         Attachments: distributed.patch, distributed.patch, distributed.patch, 
> fedsearch.patch, fedsearch.patch, fedsearch.patch, fedsearch.patch, 
> fedsearch.patch, fedsearch.patch, fedsearch.patch, fedsearch.stu.patch, 
> fedsearch.stu.patch
>
>
> Searching over multiple shards and aggregating results.
> Motivated by http://wiki.apache.org/solr/DistributedSearch

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to