Yonik could you elaborate a bit -- I'm not following ..

1) The RubyResponseWriter should never leave a hash value blank in a (k,v)
pair, it should use Nil -- this is handled in the patch. What is missing?
This, in my opinion is separate from how that value got empty/nil in the
index.

2) Which leads to Schema validation which the second patch handles.

What part of the picture am I not seeing?

Thanks for your time.

-Yousef

On 1/28/08, Yonik Seeley <[EMAIL PROTECTED]> wrote:
>
> On Jan 28, 2008 2:48 PM, Yousef Ourabi <[EMAIL PROTECTED]> wrote:
> > If I'm following along correctly the hangup is that there are really two
> > issues:
> >
> > 1) RubyResponseWriter should return NIL and not nothing (as in no
> characters
> > at all) -- fixed by: Yoniks fix_ruby_output.path applied to the
> > RubyResponseWriter
> >
> > 2) Integer fields should never be empty, and so something is going wrong
> > with the Schema validation fixed by zero_length_int.patch
> >
> > Why haven't these been applied to trunk and the issue closed?
>
> None of the patches are really complete or totally correct IMO... and
> I guess it hasn't been a high priority since it deals with handling of
> errant client input (which would still need to be fixed even if we
> fixed the validation problems in Solr).
>
> -Yonik
>

Reply via email to