[ 
https://issues.apache.org/jira/browse/SOLR-489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572262#action_12572262
 ] 

Sean Timm commented on SOLR-489:
--------------------------------

At Hoss' goading, here is my attempt at adding @deprecation tags where missing.

The attached patch fixes adds comments where (I think) it is clear to me why 
something was deprecated and what to use now.  Some files contain deprecations 
that I am less sure of--I didn't make any changes to those.  They are primarily 
related to refactoring done in SOLR-135, SOLR-215, and SOLR-301.

Additionally, I noticed that @Deprecated is commented out in two places in 
org/apache/solr/handler/XmlUpdateRequestHandler.java.  I'm not sure if that is 
meant to be commented out or not.

Here are the files which still have uncommented @Deprecation annotations.

./src/java/org/apache/solr/request/SolrQueryRequestBase.java
./src/java/org/apache/solr/request/SolrQueryRequest.java
./src/java/org/apache/solr/handler/admin/ShowFileRequestHandler.java
./src/java/org/apache/solr/handler/XmlUpdateRequestHandler.java
./src/java/org/apache/solr/tst/OldRequestHandler.java
./src/java/org/apache/solr/tst/TestRequestHandler.java
./src/java/org/apache/solr/util/TestHarness.java
./src/java/org/apache/solr/util/CommonParams.java
./src/java/org/apache/solr/core/Config.java
./src/java/org/apache/solr/core/SolrInfoRegistry.java
./src/java/org/apache/solr/core/SolrCore.java
./src/java/org/apache/solr/core/SolrConfig.java
./src/java/org/apache/solr/search/DocSet.java
./src/java/org/apache/solr/schema/IndexSchema.java
./src/java/org/apache/solr/schema/FieldType.java
./src/java/org/apache/solr/analysis/WordDelimiterFilter.java
./src/webapp/src/org/apache/solr/servlet/SolrUpdateServlet.java
./src/webapp/src/org/apache/solr/servlet/SolrServlet.java

> Added @deprecation Javadoc comments
> -----------------------------------
>
>                 Key: SOLR-489
>                 URL: https://issues.apache.org/jira/browse/SOLR-489
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Sean Timm
>            Priority: Trivial
>         Attachments: deprecationDocumentation.patch
>
>
> In a number of files, @Deprecation annotations were added without 
> accompanying @deprecation Javadoc comments to explain what to use now.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to