[ 
https://issues.apache.org/jira/browse/SOLR-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated SOLR-243:
--------------------------

    Attachment: indexReaderFactory.patch

thinking about the legacy SolrIndexSearch constructors a bit more, and how 
SolrIndexConfig is used, i realized i few things...

  * we can just always use the mainIndex config in those constructors
  * we should really deprecate one of those constructors anyway
  * we don't need to be quite as paranoid about getting the defaultIndexConfig 
if main isn't set -- SolrIndexConfig takes care of that for us.
  * there were some tabs still left in the diff.


> Create a hook to allow custom code to create custom IndexReaders
> ----------------------------------------------------------------
>
>                 Key: SOLR-243
>                 URL: https://issues.apache.org/jira/browse/SOLR-243
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 1.3
>         Environment: Solr core
>            Reporter: John Wang
>         Attachments: indexReaderFactory.patch, indexReaderFactory.patch, 
> indexReaderFactory.patch, indexReaderFactory.patch, indexReaderFactory.patch, 
> indexReaderFactory.patch, indexReaderFactory.patch
>
>
> I have a customized IndexReader and I want to write a Solr plugin to use my 
> derived IndexReader implementation. Currently IndexReader instantiation is 
> hard coded to be: 
> IndexReader.open(path)
> It would be really useful if this is done thru a plugable factory that can be 
> configured, e.g. IndexReaderFactory
> interface IndexReaderFactory{
>      IndexReader newReader(String name,String path);
> }
> the default implementation would just return: IndexReader.open(path)
> And in the newSearcher and getSearcher methods in SolrCore class can call the 
> current factory implementation to get the IndexReader instance and then build 
> the SolrIndexSearcher by passing in the reader.
> It would be really nice to add this improvement soon (This seems to be a 
> trivial addition) as our project really depends on this.
> Thanks
> -John

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to