Grant Ingersoll wrote:
More on multicore:
Would it also make sense for there to be a MultiCore(String dir, File
config) constructor that just calls load()?
In what context are you calling new MultiCore() directly? The
getInstance() bit is there so that if someone else modifies the
MultiCore settings *before* SolrDispatchFilter, those multicore settings
would be used.
Looking at it fresh, this edge use case could use a custom
SoleDispatchFilter subclass and return the MultiCore directly from:
protected MultiCore initMultiCore(FilterConfig config) { }
I'll create a quick patch and see what you guys think.
ryan
