[
https://issues.apache.org/jira/browse/SOLR-553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12596558#action_12596558
]
Otis Gospodnetic commented on SOLR-553:
---------------------------------------
For cross-reference - SOLR-575 will address merging of highlighted tokens that
are part of a phrase.
As for the direction to take with integrating the new phrase highlighting
support, I think the support for proper
highlighting of *pure phrase* queries should be added to DefaultSolrHighlighter
(DSH) and enabled via useSpanScorer.
DSH could do query instanceof PhraseQuery and run the new code if useSS is on.
Sounds reasonable?
Note that I highlighted (eh) *pure phrase*, as it seems that LUCENE-794 doesn't
fix cases where we have a phrase that
is a part of a BooleanQuery (e.g. foo AND bar OR "peanut butter")
Patch coming tomorrow...
> Highlighter does not match phrase queries correctly
> ---------------------------------------------------
>
> Key: SOLR-553
> URL: https://issues.apache.org/jira/browse/SOLR-553
> Project: Solr
> Issue Type: New Feature
> Components: highlighter
> Affects Versions: 1.2
> Environment: all
> Reporter: Brian Whitman
> Attachments: highlighttest.xml
>
>
> http://www.nabble.com/highlighting-pt2%3A-returning-tokens-out-of-order-from-PhraseQuery-to16156718.html
> Say we search for the band "I Love You But I've Chosen Darkness"
> .../selectrows=100&q=%22I%20Love%20You%20But%20I\'ve%20Chosen%20Darkness%22&fq=type:html&hl=true&hl.fl=content&hl.fragsize=500&hl.snippets=5&hl.simple.pre=%3Cspan%3E&hl.simple.post=%3C/span%3E
> The highlight returns a snippet that does have the name altogether:
> Lights (Live) : <span>I</span> <span>Love</span> <span>You</span> But
> <span>I've</span> <span>Chosen</span> <span>Darkness</span> :
> But also returns unrelated snips from the same page:
> Black Francis Shop "<span>I</span> Think <span>I</span> <span>Love</span>
> <span>You</span>"
> A correct highlighter should not return snippets that do not match the phrase
> exactly.
> LUCENE-794 (not yet committed, but seems to be ready) fixes up the problem
> from the Lucene end. Solr should get it too.
> Related: SOLR-575
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
