[
https://issues.apache.org/jira/browse/SOLR-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597455#action_12597455
]
Grant Ingersoll commented on SOLR-572:
--------------------------------------
Patch applies cleanly. Very cool that we have something concrete finally
Some thoughts:
1. I don't believe we use author tags (is this a Solr policy? I know it is a
Lucene Java convention)
2. There needs to be unit tests
3. I think it makes sense to have the option to return extended results
4. I don't think it should be a default search component, but will defer to
others.
5. numFound should be returned when count > 1 as well, right? In other words,
the structure should be the same for the response no matter what in:
{code}
if (count > 1) {
response.add("suggestions", spellChecker.getSuggestions(q, count));
} else {
NamedList suggestions = new NamedList();
suggestions.add("numFound", 1);
suggestions.add(q, spellChecker.getSuggestion(q));
response.add("suggestions", suggestions);
}
{code}
That way it can be handled uniformly on the client
> Spell Checker as a Search Component
> -----------------------------------
>
> Key: SOLR-572
> URL: https://issues.apache.org/jira/browse/SOLR-572
> Project: Solr
> Issue Type: New Feature
> Components: spellchecker
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Fix For: 1.3
>
> Attachments: SOLR-572.patch, SOLR-572.patch
>
>
> Expose the Lucene contrib SpellChecker as a Search Component. Provide the
> following features:
> * Allow creating a spell index on a given field and make it possible to have
> multiple spell indices -- one for each field
> * Give suggestions on a per-field basis
> * Given a multi-word query, give only one consistent suggestion
> * Process the query with the same analyzer specified for the source field and
> process each token separately
> * Allow the user to specify minimum length for a token (optional)
> Consistency criteria for a multi-word query can consist of the following:
> * Preserve the correct words in the original query as it is
> * Never give duplicate words in a suggestion
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
