[
https://issues.apache.org/jira/browse/SOLR-256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hoss Man updated SOLR-256:
--------------------------
Fix Version/s: 1.3
skimming the patch, i think it's worth trying to get this in 1.3 assuming
Shalin is able to ad some unit tests.
Shalin: the three things that jumped out at me when reading the patch
(unfortunately didn't have time to try testing it) is...
* not sure why the separate init method is needed in the JmxManager class
... particularly since hte rest of hte constructor should be skipped if the
init method doesn't set server ... seems simpler to just put lal of that in the
constructor.
* we should think about the situation when new "stuff" is dynamical
registered after the SolrCore starts up ... SolrCore.registerRequestHandler for
example can be called at any time. We may need to sprinkle some more hooks in
SolrCore to call JmxManager.register (and to make JmxManager.register more
resilient in case it gets called on an already register object, or when JMX is
disabled anyway)
* we should be careful about documenting what {{<jmx />}} does ... i think
in the example config you said it turns JMX monitoring on by default, but
that's not true -- it turns it on if and only if an existing MBeanServer is
found ... we should be clear about that.
> Stats via JMX
> -------------
>
> Key: SOLR-256
> URL: https://issues.apache.org/jira/browse/SOLR-256
> Project: Solr
> Issue Type: New Feature
> Components: search, update
> Reporter: Sharad Agarwal
> Priority: Minor
> Fix For: 1.3
>
> Attachments: jmx.patch, jmx.patch, jmx.patch, jmx.patch, jmx.patch,
> SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch, SOLR-256.patch
>
>
> This patch adds JMX capability to get statistics from all the SolrInfoMBean.
> The implementation is done such a way to minimize code changes.
> In SolrInfoRegistry, I have overloaded Map's put and remove methods to
> register and unregister SolrInfoMBean in MBeanServer.
> Later on, I am planning to use register and unregister methods in
> SolrInfoRegistry and removing getRegistry() method (Hiding the map instance
> to other classes)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
