I'd leave the comment, as it's still applicable. -Yonik
On Fri, May 23, 2008 at 5:32 PM, <[EMAIL PROTECTED]> wrote: > Author: otis > Date: Fri May 23 14:32:45 2008 > New Revision: 659668 > > URL: http://svn.apache.org/viewvc?rev=659668&view=rev > Log: > - Removed a TODO that does not apply any more due to SOLR-539 commit > > Modified: > lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java > > Modified: > lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java > URL: > http://svn.apache.org/viewvc/lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java?rev=659668&r1=659667&r2=659668&view=diff > ============================================================================== > --- > lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java > (original) > +++ > lucene/solr/trunk/src/java/org/apache/solr/handler/RequestHandlerBase.java > Fri May 23 14:32:45 2008 > @@ -37,15 +37,13 @@ > public abstract class RequestHandlerBase implements SolrRequestHandler, > SolrInfoMBean { > > // statistics > - // TODO: should we bother synchronizing these, or is an off-by-one error > - // acceptable every million requests or so? > volatile long numRequests; > volatile long numErrors; > + volatile long totalTime = 0; > protected NamedList initArgs = null; > protected SolrParams defaults; > protected SolrParams appends; > protected SolrParams invariants; > - volatile long totalTime = 0; > long handlerStart = System.currentTimeMillis(); > > /** shorten the class references for utilities */ > @@ -108,7 +106,7 @@ > o = args.get("invariants"); > if (o != null && o instanceof NamedList) { > invariants = SolrParams.toSolrParams((NamedList)o); > - } > + } > } > } > > > >
