[
https://issues.apache.org/jira/browse/SOLR-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar updated SOLR-506:
---------------------------------------
Attachment: SOLR-506.patch
An optional boolean init parameter "httpCaching" has been added to
RequestHandlerBase. This parameter should be set to true if emitting cache
headers is desired. By default, emitting http cache headers is disabled. Users
who desire caching must enable this for the handler they want.
The example solrconfig.xml has emitting http caching enabled for the
StandardRequestHandler, MoreLikeThisHandler and SpellCheckerRequestHandler.
I've removed explicit setHttpCaching calls in SearchHandler,
MoreLikeThisHandler and SpellCheckerRequestHandler. If a custom request handler
explictly calls the SolrQueryResponse#setHttpCaching method then it will
override the per-handler configuration in solrconfig.xml
Do we need tests for this?
svn stat follows:
M src/test/test-files/solr/conf/solrconfig-nocache.xml
M src/test/test-files/solr/conf/solrconfig.xml
M src/java/org/apache/solr/handler/RequestHandlerBase.java
M src/java/org/apache/solr/handler/component/SearchHandler.java
M src/java/org/apache/solr/handler/SpellCheckerRequestHandler.java
M src/java/org/apache/solr/handler/MoreLikeThisHandler.java
M example/solr/conf/solrconfig.xml
> Enabling HTTP Cache headers should be configurable on a per-handler basis
> -------------------------------------------------------------------------
>
> Key: SOLR-506
> URL: https://issues.apache.org/jira/browse/SOLR-506
> Project: Solr
> Issue Type: Improvement
> Affects Versions: 1.3
> Reporter: Shalin Shekhar Mangar
> Attachments: SOLR-506.patch
>
>
> HTTP cache headers are needed only for select handler's response and it does
> not make much sense to enable it globally for all Solr responses.
> Therefore, enabling/disabling cache headers should be configurable on a
> per-handler basis. It should be enabled by default on the select request
> handler and disabled by default on all others. It should be possible to
> override these defaults through configuration as well as through API.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
