[ 
https://issues.apache.org/jira/browse/SOLR-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611296#action_12611296
 ] 

Ryan McKinley commented on SOLR-605:
------------------------------------

true -- likewise with SOLR-619 -- however all these calls will be safe within 
inform( SolrCore ) for SolrCoreAware classes.

Options I see:
1. add javadoc comments saying "not threadsafe, intended for use in inform()"
2. change implementations from HashMap -> ConcurrentHashMap & List -> 
Collections.synchronized()
3. (bad) remove the functionality

Is there any way for an arbitrary thread (say in a RequestHandler) to block 
indexing?  If so, this could be offered as an option in addition to #1 for the 
rare event where you need to modify the listeners/schema after startup.




> Programatically register SolrEventListeners
> -------------------------------------------
>
>                 Key: SOLR-605
>                 URL: https://issues.apache.org/jira/browse/SOLR-605
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Ryan McKinley
>            Assignee: Ryan McKinley
>            Priority: Trivial
>             Fix For: 1.3
>
>         Attachments: SOLR-605-RegisterEventListeners.patch, SOLR-605.patch
>
>
> Currently all eventListeners need to be registered via solrconfig.xml -- it 
> would be nice to programatically register classes for these events too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to