[ 
https://issues.apache.org/jira/browse/SOLR-624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612374#action_12612374
 ] 

Hoss Man commented on SOLR-624:
-------------------------------

FWIW: issues with the amount of ram/swap needed in order to fork&exec the 
replication scripts from java is another reason i know some people cron 
snapshooter.  

short circuiting in the NOOP case out is rarely a bad idea.

one thing i notice skimming the patch: snapshot.* is used to get the list of 
all snapshots -- didn't we removed similar wildcards from the other scripts 
because it barfs when the number of snapshots gets really big?


> patch: Don't take snapshot if there are no differences
> ------------------------------------------------------
>
>                 Key: SOLR-624
>                 URL: https://issues.apache.org/jira/browse/SOLR-624
>             Project: Solr
>          Issue Type: Improvement
>          Components: replication
>    Affects Versions: 1.3
>            Reporter: Richard "Trey" Hyde
>             Fix For: 1.3
>
>         Attachments: solr.check.patch
>
>
> This is similar in concept to a change I made several years ago in Solar.   
> Cronned snapshooters can quickly generate a lot of snaps which will then be 
> unnecessarily distributed to the slaves if there hasn't been any changes in 
> that period.
> Adds a "check" argument to make sure there where changes to the index before 
> taking the snap.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to