[ 
https://issues.apache.org/jira/browse/SOLR-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12618811#action_12618811
 ] 

Shalin Shekhar Mangar commented on SOLR-622:
--------------------------------------------

bq. I think the callback happens before the new searcher is opened.
Yes, the searcher is being created after informing the listeners. IMO, that 
seems a bit counter-intuitive. The commit has happened so I would expect to see 
the new data.

bq. We have warming mechanism that works for stuff like this... perhaps that is 
what should be used rather than postCommit callbacks?
So the way used in the latest patch using a newSearcher event should be fine, 
right? It is done in a separate thread through ExecutorService in SolrCore.

Not relevant to this issue but the newSearcher method is always called with a 
null currentSearcher, why is that? I mentioned it at 
http://www.nabble.com/Question-on-newSearcher-and-commit-callbacks-tp18667573p18667573.html



> SpellCheckComponent should build or load indices on startup and commits
> -----------------------------------------------------------------------
>
>                 Key: SOLR-622
>                 URL: https://issues.apache.org/jira/browse/SOLR-622
>             Project: Solr
>          Issue Type: Improvement
>          Components: spellchecker
>    Affects Versions: 1.3
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: SOLR-622.patch, SOLR-622.patch
>
>
> SpellCheckComponent must be able to build/load spell check index on startup 
> and commits. With SOLR-605, SpellCheckComponent can register an event 
> listener for firstSearcher and newSearcher events and rebuild/reload indices 
> as appropriate.
> * If index uses a FSDirectory and exists on disk then just reload it or else 
> build it on firstSearcher event.
> * If index is built from a Solr field then re-build it on newSearcher event.
> This will help avoid having to add QuerySenderListener in configuration and 
> will not force people to issue build on first query.
> All this should be configurable so that people who don't want to rebuild on 
> commits should be able to turn this feature off per configured spell checker.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to