[ https://issues.apache.org/jira/browse/SOLR-545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-545: ------------------------------- Attachment: SOLR-545-path-access.patch Henri - thanks for your help on this.... a couple comments. It would be nice to keep solr-647 as in independent issue. I would rather have Yonik verify all the ref counted stuff. I'm not a big fan of adding the 'strict' parameter to web.xml -- the behavior should be well defined simply from the external configs (multicore(solr).xml / solrconfig.xml) Currently, I see two problems with the RequestDispatcher: 1. it has a lot of crazy path checking 2. It has incorrect behavior for /select and /admin/ in a "multicore" environment The attached patch only helps with #2 and does not make #1 worse -- In the deprecated SolrServlet, it checks the existance of multicore.xml (soon to be solr.xml) and throws an error if it exists. For the /admin side, we throw an error if the DispatchFilter does not set the core > remove MultiCore "default" core / cleanup DispatchHandler > --------------------------------------------------------- > > Key: SOLR-545 > URL: https://issues.apache.org/jira/browse/SOLR-545 > Project: Solr > Issue Type: Bug > Affects Versions: 1.3 > Reporter: Ryan McKinley > Assignee: Ryan McKinley > Fix For: 1.3 > > Attachments: SOLR-545-path-access.patch, solr-545.patch, > solr-545.patch, solr-545.patch, solr-545.patch > > > MultiCore should require a core name in the URL. If the core name is > missing, there should be a 404, not a valid core. That is: > http://localhost:8983/solr/select?q=*:* should return 404. > While we are at it, we should cleanup the DispatchHandler. Perhaps the best > approach is to treat single core as multicore with only one core? As is the > tangle of potential paths is ugly. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.