[ https://issues.apache.org/jira/browse/SOLR-236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621470#action_12621470 ]
Matthias Epheser commented on SOLR-236: --------------------------------------- I just tried to apply the last patch and ran into 2 issues: First: The new getDocListAndSet(Query query, List<Query>..) method in SolrIndexSearcher calls the getDocListC(..) method using the old signature. I changed the call to the new signature and it worked very well: DocListAndSet ret = new DocListAndSet(); QueryResult queryResult = new QueryResult(); queryResult.setDocListAndSet(ret); queryResult.setPartialResults(false); QueryCommand queryCommand = new QueryCommand(); queryCommand.setQuery(query); queryCommand.setFilterList(filterList); queryCommand.setFilter(docSet); queryCommand.setSort(lsort); queryCommand.setOffset(offset); queryCommand.setLen(len); queryCommand.setFlags(flags |= GET_DOCSET); getDocListC(queryResult, queryCommand); Second: After adding more docs (~3000), I got an Exception in SolrIndexSearcher at line ~1300: qr.setDocSet(filter == null ? qDocSet : qDocSet.intersection(filter)); As the NegotiatedDocSet doesn't implement the iterator() function, this call lead to an Unsupported Operation exception. I just naively tried to implement this funtion using "return source.iterator()". Works fine for me. As the first issue is very clear, I wanted to check my approach for the second one before I post a patch. Maybe there are some side effects that I missed. > Field collapsing > ---------------- > > Key: SOLR-236 > URL: https://issues.apache.org/jira/browse/SOLR-236 > Project: Solr > Issue Type: New Feature > Components: search > Affects Versions: 1.3 > Reporter: Emmanuel Keller > Assignee: Otis Gospodnetic > Attachments: field-collapsing-extended-592129.patch, > field_collapsing_1.1.0.patch, field_collapsing_1.3.patch, > field_collapsing_dsteigerwald.diff, field_collapsing_dsteigerwald.diff, > field_collapsing_dsteigerwald.diff, SOLR-236-FieldCollapsing.patch, > SOLR-236-FieldCollapsing.patch, SOLR-236-FieldCollapsing.patch, solr-236.patch > > > This patch include a new feature called "Field collapsing". > "Used in order to collapse a group of results with similar value for a given > field to a single entry in the result set. Site collapsing is a special case > of this, where all results for a given web site is collapsed into one or two > entries in the result set, typically with an associated "more documents from > this site" link. See also Duplicate detection." > http://www.fastsearch.com/glossary.aspx?m=48&amid=299 > The implementation add 3 new query parameters (SolrParams): > "collapse.field" to choose the field used to group results > "collapse.type" normal (default value) or adjacent > "collapse.max" to select how many continuous results are allowed before > collapsing > TODO (in progress): > - More documentation (on source code) > - Test cases > Two patches: > - "field_collapsing.patch" for current development version > - "field_collapsing_1.1.0.patch" for Solr-1.1.0 > P.S.: Feedback and misspelling correction are welcome ;-) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.