Then it should be part of that patch, not this one. But, I still
don't think it belongs in CoreDescriptor.
On Aug 12, 2008, at 10:36 AM, Shalin Shekhar Mangar wrote:
It is needed for SOLR-561 (core reload for config replication)
On Tue, Aug 12, 2008 at 8:01 PM, Grant Ingersoll
<[EMAIL PROTECTED]>wrote:
OK, I'll buy that, maybe I just don't get Multicore/Single Core
relationship. Also, reload is not used anywhere and we've never
had the
notion of reloading in the single core case, AFAICT.
-Grant
On Aug 12, 2008, at 9:48 AM, Noble Paul (JIRA) wrote:
[
https://issues.apache.org/jira/browse/SOLR-647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621817
#action_12621817
]
Noble Paul commented on SOLR-647:
---------------------------------
bq.How does CoreDescriptor.reloadCore factor in? I don't see that
it is
used. Why would I call that instead of MultiCore.reload()?
How else can I reload the core in a single core deployment?
Do SolrCore.close() in a refcounted way
---------------------------------------
Key: SOLR-647
URL: https://issues.apache.org/jira/browse/SOLR-647
Project: Solr
Issue Type: Bug
Affects Versions: 1.3
Reporter: Noble Paul
Assignee: Grant Ingersoll
Fix For: 1.3
Attachments: solr-647.patch, solr-647.patch, solr-647.patch,
solr-647.patch, solr-647.patch, SOLR-647.patch, SOLR-647.patch
The method _SolrCore.close()_ directly closes the core . It can
cause
Exceptions for in-flight requests. The _close()_ method should
just do a
decrement on refcount and the actual close must happen when the
last request
being processed by that core instance is completed
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
--
Regards,
Shalin Shekhar Mangar.
--------------------------
Grant Ingersoll
http://www.lucidimagination.com
Lucene Helpful Hints:
http://wiki.apache.org/lucene-java/BasicsOfPerformance
http://wiki.apache.org/lucene-java/LuceneFAQ
